Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various issues #124

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Conversation

huyenltnguyen
Copy link
Member

Checklist:

This PR fixes the following issues:

  • Search box having nested focus line on focus
  • Advanced search button not having correct icon color
  • Buttons in the editor having a border (pointed out by Ilenia)
  • Disclosure widget text being unreadable on hover (closes Disclosure widget text is not readable on hover #110)
Screenshots
Issue Before After
Focus outline Screenshot 2024-04-19 at 22 39 36 Screenshot 2024-04-19 at 22 39 25
Advanced search button Screenshot 2024-04-19 at 23 25 51 Screenshot 2024-04-19 at 23 26 12
Editor buttons Screenshot 2024-04-19 at 22 38 52 Screenshot 2024-04-19 at 22 38 33
Disclosure widget Screenshot 2024-04-19 at 23 29 59 Screenshot 2024-04-19 at 22 51 51

@huyenltnguyen huyenltnguyen requested a review from a team as a code owner April 19, 2024 16:33
@raisedadead raisedadead merged commit 8e9fbc8 into freeCodeCamp:main Apr 19, 2024
1 check passed
@huyenltnguyen huyenltnguyen deleted the fix/various-stuff branch April 22, 2024 04:23
@huyenltnguyen huyenltnguyen mentioned this pull request Apr 23, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disclosure widget text is not readable on hover
2 participants