Refactor dependencies for tool output actions. #19662
Draft
+143
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
refactor_tool_dependency
branch
2 times, most recently
from
fe92e1a to
4db8642
Compare
Eliminates a Tool import in the parser stuff that shouldn't be there. Catches a bunch of little bugs that were found by introducing better typing in these components. The output action models still need to spun out from the runtime at some point the way we did for parameter validators, etc.. but these changes will aid that.
jmchilton
force-pushed
the
refactor_tool_dependency
branch
from
4db8642 to
7d8069c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates a Tool import in the parser stuff that shouldn't be there and implements a better design around how tool output actions are implementation regardless of imports and package structure. Also catches a few little bugs (e.g. around null handling) that were found by introducing better typing in these components.
The output action models still need to spun out from the runtime at some point the way we did for parameter validators, etc.. but these changes will aid that.
How to test the changes?
(Select all options that apply)
License