Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19692
This is the easy fix. The real issue is here:
galaxy/client/src/components/DataDialog/model.js
Line 36 in 3f01d5b
So the type defined in the event was incorrect:
galaxy/client/src/components/DataDialog/DataDialog.vue
Line 47 in 3f01d5b
The values returned depend on the
format
prop so the real type is certainlyunknown
.We could still try to convert
components/DataDialog/model.js
to Typescript and try to do some Typescript black magic to define the proper type... react to this PR with:How to test the changes?
License