Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated version of pretext workflow developed by Delphine that takes HiFi and HiC as input. #584

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

Smeds
Copy link

@Smeds Smeds commented Oct 28, 2024

updated version of pretext workflow developed by Delphine that takes HiFi and HiC as input.

@Smeds Smeds marked this pull request as draft October 28, 2024 14:03
@Smeds Smeds changed the title feat: updated version of pretext workflow developed by Delphine that … feat: updated version of pretext workflow developed by Delphine that takes HiFi and HiC as input. Oct 28, 2024
@mvdbeek
Copy link
Member

mvdbeek commented Oct 30, 2024

@Smeds
Copy link
Author

Smeds commented Oct 30, 2024

Nice! Can you take a look at https://github.com/galaxyproject/iwc/blob/main/workflows/README.md#adding-workflows ?

Thanks! I will read through the readme and update the workflow.

@Delphine-L
Copy link
Contributor

Need to solve galaxyproject/galaxy#19143 as soon as possible to settle on a way to deal with compressed haplotypes inputs

@Delphine-L Delphine-L marked this pull request as ready for review November 26, 2024 03:37
@Delphine-L
Copy link
Contributor

I am not sure why the tests are not running. Could someone take a look ?

@mvdbeek
Copy link
Member

mvdbeek commented Nov 26, 2024

Screenshot 2024-11-26 at 09 51 41

I assume that's the reason ?

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge this, but I'd urge you to think of better folder and workflow names. if you look at https://github.com/orgs/iwc-workflows/repositories?type=all most folders/repos are all-lowercase, I think that looks much nicer once we publish that to https://iwc.galaxyproject.org/.

Copy link

Test Results (powered by Planemo)

Test Summary

Test State Count
Total 0
Passed 0
Error 0
Failure 0
Skipped 0

@Delphine-L Delphine-L added autoupdate 'artefact' Autoupdate generated a new version but does not worth releasing it and removed autoupdate 'artefact' Autoupdate generated a new version but does not worth releasing it labels Feb 4, 2025
Copy link

Test Results (powered by Planemo)

Test Summary

Test State Count
Total 1
Passed 0
Error 1
Failure 0
Skipped 0
Errored Tests
  • ❌ hi-c-map-for-assembly-manual-curation.ga_0

    Execution Problem:

    • Unexpected HTTP status code: 400: {"err_msg":"Workflow cannot be run because input step '49' (Haplotype 2) is not optional and no input provided.","err_code":0}
      

@Delphine-L
Copy link
Contributor

@Smeds @mvdbeek I'd be grateful for feedback on the latest version of the workflow.

I modified the workflow to :

  1. use bwameme2 on paired collection instead of the filter and merge tool
  2. take either 1 or 2 haplotypes
  3. generate pretext maps with coverage and gaps even if telomeres track is empty (with all 3 tracks if not). I am not sure how often it could happen that no telomeres are detected, but it's there just in case.

Tests are :

  1. one haplotype with telomeres found
  2. one haplotype without telomeres found

I am not testing for 2 haplotypes right now because it takes too much memory for the CI to run, I am working on using smaller scaffolds to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants