-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated version of pretext workflow developed by Delphine that takes HiFi and HiC as input. #584
base: main
Are you sure you want to change the base?
Conversation
…takes HiFi and HiC as input.
Nice! Can you take a look at https://github.com/galaxyproject/iwc/blob/main/workflows/README.md#adding-workflows ? |
Thanks! I will read through the readme and update the workflow. |
... and modify the replacement expressions so that users don't have to add the &. to the suffixes
… go around the fasta implicit conversion problem
Need to solve galaxyproject/galaxy#19143 as soon as possible to settle on a way to deal with compressed haplotypes inputs |
I am not sure why the tests are not running. Could someone take a look ? |
workflows/VGP-assembly-v2/Pre-Curation_PretextMap/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-Curation_PretextMap/PretextMap_Generation-tests.yml
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-Curation_PretextMap/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-Curation_PretextMap/PretextMap_Generation-tests.yml
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-Curation_PretextMap/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-Curation_PretextMap/.dockstore.yml
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation-tests.yml
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation-tests.yml
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/README.md
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/README.md
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can merge this, but I'd urge you to think of better folder and workflow names. if you look at https://github.com/orgs/iwc-workflows/repositories?type=all most folders/repos are all-lowercase, I think that looks much nicer once we publish that to https://iwc.galaxyproject.org/.
Test Results (powered by Planemo)Test Summary
|
Test Results (powered by Planemo)Test Summary
Errored Tests
|
@Smeds @mvdbeek I'd be grateful for feedback on the latest version of the workflow. I modified the workflow to :
Tests are :
I am not testing for 2 haplotypes right now because it takes too much memory for the CI to run, I am working on using smaller scaffolds to test it. |
updated version of pretext workflow developed by Delphine that takes HiFi and HiC as input.