Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Adds Feedback Widget Maestro E2E tests #4604

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Feb 26, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Note: I'm targeting main with this PR since the changes involve only additional tests. For the feedback related feature changes/additions (e.g.) I'll use feedback-ui-2

📜 Description

Adds Feedback Widget Maestro E2E tests

💡 Motivation and Context

Part of #4302

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 380.68 ms 442.02 ms 61.34 ms
Size 17.75 MiB 20.12 MiB 2.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
40c35c5 438.38 ms 437.52 ms -0.86 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
c2a4e9b 480.42 ms 485.60 ms 5.18 ms
5a22220 412.38 ms 447.35 ms 34.97 ms
397a69c 425.02 ms 423.40 ms -1.63 ms
8bda0cc 450.38 ms 433.89 ms -16.49 ms
ae7b03d 428.82 ms 412.33 ms -16.49 ms
484813b 434.55 ms 452.31 ms 17.75 ms
3853f43 329.68 ms 346.32 ms 16.64 ms
7d161c0 413.02 ms 435.29 ms 22.26 ms

App size

Revision Plain With Sentry Diff
40c35c5 17.75 MiB 20.11 MiB 2.37 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
c2a4e9b 17.73 MiB 20.06 MiB 2.33 MiB
5a22220 17.73 MiB 19.93 MiB 2.20 MiB
397a69c 17.75 MiB 20.12 MiB 2.37 MiB
8bda0cc 17.75 MiB 20.11 MiB 2.36 MiB
ae7b03d 17.75 MiB 20.11 MiB 2.37 MiB
484813b 17.73 MiB 20.07 MiB 2.33 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
7d161c0 17.75 MiB 20.12 MiB 2.37 MiB

Copy link
Contributor

github-actions bot commented Feb 26, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.81 ms 1230.18 ms 5.37 ms
Size 2.63 MiB 3.75 MiB 1.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4161236+dirty 1213.47 ms 1215.28 ms 1.81 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
db44eaf+dirty 1227.09 ms 1230.65 ms 3.56 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
bab7feb+dirty 1233.88 ms 1236.65 ms 2.78 ms
b7eb05d+dirty 1215.71 ms 1221.38 ms 5.67 ms
1c65324+dirty 1235.17 ms 1235.08 ms -0.09 ms
a0df630+dirty 1222.02 ms 1219.10 ms -2.92 ms
1332acb+dirty 1230.53 ms 1234.54 ms 4.01 ms
e1ea4a8+dirty 1233.49 ms 1237.71 ms 4.22 ms

App size

Revision Plain With Sentry Diff
4161236+dirty 2.63 MiB 3.69 MiB 1.05 MiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
db44eaf+dirty 2.36 MiB 3.10 MiB 755.81 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
bab7feb+dirty 2.63 MiB 3.74 MiB 1.11 MiB
b7eb05d+dirty 2.63 MiB 3.75 MiB 1.12 MiB
1c65324+dirty 2.36 MiB 3.04 MiB 698.64 KiB
a0df630+dirty 2.63 MiB 3.70 MiB 1.06 MiB
1332acb+dirty 2.36 MiB 3.11 MiB 759.86 KiB
e1ea4a8+dirty 2.36 MiB 3.10 MiB 752.31 KiB

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 371.90 ms 364.08 ms -7.81 ms
Size 7.15 MiB 8.39 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d361d38+dirty 257.72 ms 318.76 ms 61.04 ms
a18210a+dirty 406.49 ms 453.94 ms 47.45 ms
0ebca77+dirty 360.94 ms 402.24 ms 41.30 ms
fc150fe+dirty 409.55 ms 407.37 ms -2.18 ms
e99226d+dirty 413.20 ms 460.37 ms 47.17 ms
5852d77+dirty 378.83 ms 381.89 ms 3.06 ms
9282172+dirty 363.57 ms 399.78 ms 36.20 ms
83f6f6c+dirty 442.82 ms 487.48 ms 44.66 ms
de59d3a+dirty 439.90 ms 454.20 ms 14.30 ms
13f280b+dirty 376.13 ms 406.41 ms 30.28 ms

App size

Revision Plain With Sentry Diff
d361d38+dirty 7.15 MiB 8.08 MiB 959.34 KiB
a18210a+dirty 7.15 MiB 8.38 MiB 1.23 MiB
0ebca77+dirty 7.15 MiB 8.22 MiB 1.07 MiB
fc150fe+dirty 7.15 MiB 8.38 MiB 1.23 MiB
e99226d+dirty 7.15 MiB 8.38 MiB 1.23 MiB
5852d77+dirty 7.15 MiB 8.38 MiB 1.22 MiB
9282172+dirty 7.15 MiB 8.37 MiB 1.22 MiB
83f6f6c+dirty 7.15 MiB 8.37 MiB 1.22 MiB
de59d3a+dirty 7.15 MiB 8.38 MiB 1.23 MiB
13f280b+dirty 7.15 MiB 8.35 MiB 1.20 MiB

Copy link
Contributor

github-actions bot commented Feb 26, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.16 ms 1234.14 ms 1.98 ms
Size 3.19 MiB 4.32 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4161236+dirty 1245.33 ms 1245.63 ms 0.30 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
db44eaf+dirty 1238.49 ms 1236.56 ms -1.93 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
bab7feb+dirty 1218.80 ms 1220.57 ms 1.78 ms
b7eb05d+dirty 1234.69 ms 1242.52 ms 7.83 ms
1c65324+dirty 1239.71 ms 1239.86 ms 0.15 ms
a0df630+dirty 1211.12 ms 1216.02 ms 4.90 ms
1332acb+dirty 1243.98 ms 1241.12 ms -2.86 ms
e1ea4a8+dirty 1228.98 ms 1222.80 ms -6.18 ms

App size

Revision Plain With Sentry Diff
4161236+dirty 3.19 MiB 4.25 MiB 1.06 MiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
db44eaf+dirty 2.92 MiB 3.66 MiB 761.15 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
bab7feb+dirty 3.19 MiB 4.31 MiB 1.12 MiB
b7eb05d+dirty 3.19 MiB 4.32 MiB 1.13 MiB
1c65324+dirty 2.92 MiB 3.61 MiB 705.56 KiB
a0df630+dirty 3.19 MiB 4.26 MiB 1.08 MiB
1332acb+dirty 2.92 MiB 3.67 MiB 772.45 KiB
e1ea4a8+dirty 2.92 MiB 3.66 MiB 756.65 KiB

@antonis antonis changed the title test(e2e): Feedback Widget Maestro tests test(e2e): Adds Feedback Widget Maestro E2E tests Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant