Skip to content

[deno] Don't report support for native-only features #7813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

andyleiserson
Copy link
Contributor

@andyleiserson andyleiserson commented Jun 16, 2025

Fixes #7796

Mask the adapter-supported features returned by wgpu before returning them to Javascript, to include only WebGPU-defined features.

This fixes the CTS test in #7796, but only after the error reporting changes go in (#7820). I've also added a dedicated test to cts_runner.

Squash or Rebase? Squash.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@andyleiserson andyleiserson requested review from crowlKats and a team as code owners June 16, 2025 19:13
@andyleiserson
Copy link
Contributor Author

I guess the tests need GPU config stuff to work in CI. I'm not inclined to mess with that right now, I would probably revert the CI changes and put a comment in the cts_runner/tests/integration.rs mentioning that they don't run in CI. (We still get coverage from the CTS job.)

@cwfitzgerald
Copy link
Member

@crowlKats discussing this in the maintainers meeting - didn't deno intend to expose native features as well?

@cwfitzgerald cwfitzgerald assigned crowlKats and unassigned crowlKats Jun 18, 2025
@andyleiserson
Copy link
Contributor Author

My intention was that the features would still work if requested -- they just won't be reported if you query the features. This may not be ideal, because the applications is probably not supposed to ask for features that aren't reported, and also because it relies on the application having some out-of-band knowledge of which non-WebGPU features are available, but it seemed like a reasonable short-term compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deno] Some CTS tests are failing on Mac due to requesting the mappable-primary-buffers feature
3 participants