Set editor's translation domain at root node #103447
Open
+2
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KoBeWi found that some strings in the save file confirm dialog are not translated (e.g. window title):
This is because the dialog has recently been given the possibility to be reparented to the root node. However, the translation domain of the editor only takes effect on the
EditorNode
node, so auto translation won't work.godot/editor/editor_node.cpp
Lines 5750 to 5754 in 15ff450
Changing the translation domain to be set at the root node can also help to resolve other potential similar issues as well.