Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set editor's translation domain at root node #103447

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Mar 2, 2025

@KoBeWi found that some strings in the save file confirm dialog are not translated (e.g. window title):

image

This is because the dialog has recently been given the possibility to be reparented to the root node. However, the translation domain of the editor only takes effect on the EditorNode node, so auto translation won't work.

godot/editor/editor_node.cpp

Lines 5750 to 5754 in 15ff450

void EditorNode::_prepare_save_confirmation_popup() {
if (save_confirmation->get_window() != get_last_exclusive_window()) {
save_confirmation->reparent(get_last_exclusive_window());
}
}

Changing the translation domain to be set at the root node can also help to resolve other potential similar issues as well.

@timothyqiu timothyqiu requested a review from a team as a code owner March 2, 2025 01:06
@KoBeWi KoBeWi added this to the 4.5 milestone Mar 2, 2025
@AThousandShips AThousandShips added the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release regression topic:editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants