Fix missing tooltips on "Advanced Import Settings for Scene" window #104804
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
fire
approved these changes
Mar 30, 2025
fire
reviewed
Mar 30, 2025
Calinou
reviewed
Mar 31, 2025
Calinou
reviewed
Mar 31, 2025
In Godot, it's possible to customize how the engine imports 3D resource, by either clicking "Advanced..." button on Import Dock or double clicking the resource on FileSystem Dock. Doing so will open the Advanced Import Settings window, where user could inspect the 3D resource in a viewport, with the scene tree on the left and an inspector panel akin to the Import dock on the left. It contains the same settings from the Import dock, with some advanced additions. This commit fixes a regression since 4.2 where settings in the inspector panel on the right part of the window does not contain the same tooltips as its Import Dock counterpart (which were retrieved from the XML class reference).
etherealxx
force-pushed
the
fix-advanced-import-inspector-missing-tooltip
branch
from
6694006 to
7e00ea5
Compare
Calinou
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #83484
This commit fixes a regression since 4.2 where settings in the inspector panel on the right part of the "Advanced Import Settings for Scene" window does not contain the same tooltips as its Import Dock counterpart (which were retrieved from the XML class reference).
Before (4.4.1.stable) :
After:
The fix are borrowed from the Import Dock code (
editor\import_dock.cpp) that has the same tooltips.Note: I don't think hard coding "ResourceImporterScene" as the object class is the best idea, perhaps those who knows the source better could help? Though i think it's safe for this case?