Rework oriented containers #64724
Rework oriented containers #64724
Conversation
|
Love the icons 😄 Personally, I like the approach here, with keeping the variations available and making them non-mutable. But I suspect not everyone will like that. |
|
I love it! It keeps the dimensions appropriately when flipping coordinates, it's very clever. Probably the more expected behaviour that can be easily overridden by flipping x and y back in script. |
|
I don't get it. Why keep the |
|
Because |
|
To me it's useful to be able to look in the SceneTree dock and see the orientation and how containers differ, rather than a soup of diagonal containers that doesn't tell much. There is no way to change the icon based on a property atm, the technology isn't there yet Edit: But to be honest, I would only use BoxContainer if displaying a different icon based on orientation ever becomes possible. |
Then I just don't see the point of this PR. If anything, it would just make things confusing. |
|
The PR doesn't change much. Users can still use H/VBoxContainers, advanced users can use BoxContainer. The only difference is that BoxContainer is no longer grayed-out and you can click it. Maybe the intended usage could be better clarified in the docs, but other than that it's fine IMO. |
| @@ -73,7 +79,7 @@ class HBoxContainer : public BoxContainer { | |||
|
|
|||
| public: | |||
| HBoxContainer() : | |||
| BoxContainer(false) {} | |||
| BoxContainer(false) { is_fixed = true; } | |||
There was a problem hiding this comment.
| BoxContainer(false) { is_fixed = true; } | |
| BoxContainer(false), | |
| is_fixed(true) {} |
Same for others.
There was a problem hiding this comment.
Does not work, I get C2614 illegal member initialization: 'is_fixed' is not a base or member error :/
There was a problem hiding this comment.
Ah that's weird. I guess it's fine as is then.
KoBeWi
force-pushed
the
HVBoxContainer
branch
2 times, most recently
from
2b6134e to
1e8aa99
Compare
KoBeWi
force-pushed
the
HVBoxContainer
branch
from
1e8aa99 to
73929be
Compare
|
Thanks! |
|
What about other H/V classes? |
|
They are not container. |
This PR makes BoxContainer, SplitContainer and FlowContainer non-abstract, so you can change the orientation on the fly using a
verticalproperty:The property is not available in the specialized classes and trying to change it from code in these classes results in an error:
Related to godotengine/godot-proposals#3558
Helps #36040