-
Notifications
You must be signed in to change notification settings - Fork 125
deps!: Remove support for Python 3.8 #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit removes Python 3.8 from the supported versions. Updates include changes in noxfiles, GitHub workflows, setup.py, Kokoro configurations, and documentation to reflect Python 3.9 as the minimum supported version.
This commit addresses items missed in the initial Python 3.8 removal: * Adds `kokoro/presubmit/system-3.9.cfg`. * Updates example commands in `CONTRIBUTING.rst`. * Modifies the warning in `pandas_gbq/__init__.py` for Python < 3.9. * Updates Python versions in `owlbot.py`. * Removes 3.8-specific line from `samples/snippets/requirements.txt`. * Populates `testing/constraints-3.9.txt` with correct lower bounds.
@@ -11,14 +11,14 @@ | |||
from .gbq import read_gbq, to_gbq # noqa | |||
|
|||
sys_major, sys_minor, sys_micro = _versions_helpers.extract_runtime_version() | |||
if sys_major == 3 and sys_minor in (7, 8): | |||
if sys_major == 3 and sys_minor < 9: | |||
warnings.warn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe raise an error instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the Python docs: FutureWarning: Base category for warnings about deprecated features when those warnings are intended for end users of applications that are written in Python.
I suspect for a small window of time this library will likely still run under 3.7 or 3.8. At some point we will introduce a 3.9+ only feature and then things will get hairy.
For now, the use of a FutureWarning
(which end users will see under the default settings of the warnings module) seems like a slightly less jarring way to migrate end users toward running 3.9.
This commit removes Python 3.8 from the supported versions. Updates include changes in noxfiles, GitHub workflows, setup.py, Kokoro configurations, and documentation to reflect Python 3.9 as the minimum supported version.