-
Notifications
You must be signed in to change notification settings - Fork 126
deps!: Remove support for Python 3.8 #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
87b00d1
Remove support for Python 3.8
google-labs-jules[bot] d58423d
Apply follow-up changes for Python 3.8 removal
google-labs-jules[bot] 5fea48f
Update pandas_gbq/__init__.py
chalmerlowe 9b50b36
Update samples/snippets/noxfile.py
chalmerlowe c96c2a8
Update requirements.txt
chalmerlowe c2c7823
Update testing/constraints-3.9.txt
chalmerlowe b65bc52
Update owlbot.py
chalmerlowe 2118f2c
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,5 +3,5 @@ | |
# Only run the following session(s) | ||
env_vars: { | ||
key: "NOX_SESSION" | ||
value: "system-3.8" | ||
} | ||
value: "system-3.9" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
google-cloud-bigquery-storage==2.29.1 | ||
google-cloud-bigquery==3.30.0 | ||
pandas-gbq==0.28.0 | ||
pandas===2.0.3; python_version == '3.8' | ||
pandas==2.2.3; python_version >= '3.9' | ||
pyarrow==19.0.1; python_version >= '3.9' | ||
pandas==2.2.3 | ||
pyarrow==19.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,22 @@ | ||
# This constraints file is used to check that lower bounds | ||
# are correct in setup.py | ||
# List *all* library dependencies and extras in this file. | ||
# Pin the version to the lower bound. | ||
# | ||
# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev", | ||
# Then this file should have foo==1.14.0 | ||
db-dtypes==1.0.4 | ||
numpy==1.19.4 | ||
pandas==1.1.4 | ||
pyarrow==4.0.0 | ||
pydata-google-auth==1.5.0 | ||
google-api-core==2.10.2 | ||
google-auth==2.13.0 | ||
google-auth-oauthlib==0.7.0 | ||
google-cloud-bigquery==3.4.2 | ||
packaging==22.0.0 | ||
# Extras | ||
google-cloud-bigquery-storage==2.16.2 | ||
tqdm==4.23.0 | ||
geopandas==0.9.0 | ||
Shapely==1.8.4 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe raise an error instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the Python docs:
FutureWarning: Base category for warnings about deprecated features when those warnings are intended for end users of applications that are written in Python.
I suspect for a small window of time this library will likely still run under 3.7 or 3.8. At some point we will introduce a 3.9+ only feature and then things will get hairy.
For now, the use of a
FutureWarning
(which end users will see under the default settings of the warnings module) seems like a slightly less jarring way to migrate end users toward running 3.9.