-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Codecov upload with token #115384
Fix Codecov upload with token #115384
Conversation
This will probably have to wait until the flaky test in bucket 4 has been fixed. It's failing in PRs at the moment. |
Co-authored-by: Martin Hjelmare <[email protected]>
that test seems to run fine the first time but fails with
|
#115437 is with secrets running from a fork |
We've also done a bit of testing and switched zigpy repos to using codecov-action v4 with secrets. Related PRs linked in: |
For PR from forks, we've had no issues with basically the same codecov setup on all zigpy repos. #115437 also passed now and has the codecov checks visible 🎉 IMO, we should be good to go with this. |
Thanks @TheJulianJES |
Proposed change
This fixes the Codecov action by properly using the GitHub secrets token for runs in the main repo.
When Codecov v4 is running in a fork, it'll ignore the provided token (will be empty due to the missing GitHub secret) and forces a tokenless upload.
Built upon the work Nick did in #115321, this also removes wretry, as it should no longer be needed with Codecov v4.
Do note that on forks, "random" failures might still occur sometimes, as tokenless uploads are constrained by the GitHub API rate limit. Runs on the main repo should "always" work now, as token uploads are not constrained by that API limit.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: