Allow specifying SIP username for outgoing calls #137059
Open
+37
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @balloob, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
|
Updated documentation for change home-assistant/home-assistant.io#37264 |
balloob
reviewed
Feb 3, 2025
| @@ -12,4 +12,7 @@ | |||
| "sleep_ratio": 0.99, | |||
| } | |||
|
|
|||
| DEFAULT_SIP_USER = "HA" | |||
There was a problem hiding this comment.
Could this impact how systems respond? Why not drop the user if it's not set.
balloob
reviewed
Feb 3, 2025
| @@ -70,7 +73,35 @@ async def async_step_init( | |||
| CONF_SIP_PORT, | |||
| SIP_PORT, | |||
| ), | |||
| ): cv.port | |||
| ): cv.port, | |||
| vol.Optional("enable_advanced"): bool, | |||
There was a problem hiding this comment.
Lets do it without advanced checkbox. Guess its all advanced anyway.
Allow configuring a SIP username to be sent in outgoing call requests to identify the home assistant source endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring a SIP username to be sent in outgoing call requests to identify the home assistant source endpoint.
Proposed change
Allow configuring a SIP username to be sent in outgoing call requests to identify the home assistant source endpoint.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: