-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VoIP configuration information #37264
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request updates the VoIP integration documentation by adding a new paragraph that explains how to configure the VoIP integration to listen on a specific port when running alongside other VoIP software. It also provides guidance for users regarding the specification of a SIP user value for outgoing calls, which will be sent to the phone in the From header if required. There are no changes to the declarations of exported or public entities. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/voip.markdown (1)
28-29
: Enhance Readability and Consistency in the New Configuration InstructionsThe newly added paragraph clearly outlines how to configure the port and handle the username for outgoing calls. For better clarity, consider adding commas to separate clauses and ensuring consistent formatting for template markup (e.g., use
{% term integration %}
instead of{%term integration %}
if that is the standard elsewhere in the document).Suggested diff:
-If you are running Home Assistant on a machine with other VoIP software you can configure the port the **VoIP** {%term integration %} listens on in the configuration. For outgoing calls, if your phone requires specifying a username check the "advanced options" box in the configuration and enter the username on the next page. +If you are running Home Assistant on a machine with other VoIP software, you can configure the port the **VoIP** {% term integration %} listens on in the configuration. For outgoing calls, if your phone requires specifying a username, check the "advanced options" box in the configuration and enter the username on the next page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/voip.markdown (1)
28-29
: Punctuation & Clarity EnhancementA comma is likely needed after “other VoIP software” for improved readability. Additionally, the sentence about outgoing calls is somewhat fragmented. Consider rephrasing the paragraph for better clarity. For example:
-If you are running Home Assistant on a machine with other VoIP software you can configure the port the **VoIP** {%term integration %} listens on in the configuration. For outgoing calls, if you can specify a SIP user value that will be sent to the phone in the From header if required. +If you are running Home Assistant on a machine with other VoIP software, you can configure the port on which the **VoIP** {% term integration %} listens in your configuration. Additionally, for outgoing calls, you can specify a SIP user value that will be sent in the From header if required.This change addresses the static analysis hint about the missing comma and improves sentence structure for better user understanding.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~28-~28: A comma might be missing here.
Context: ... Assistant on a machine with other VoIP software you can configure the port the VoIP...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/voip.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/voip.markdown
[uncategorized] ~28-~28: A comma might be missing here.
Context: ... Assistant on a machine with other VoIP software you can configure the port the VoIP...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
Proposed change
Add information about configuring the VoIP integration, including changes to configuration introduced by home-assistant/core#137059 .
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit