Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include extra metadata in backup WS API #137296

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Feb 4, 2025

Proposed change

Include extra metadata in backup WS API

Needed by home-assistant/frontend#24044

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@emontnemery emontnemery added this to the 2025.2.0 milestone Feb 4, 2025
Comment on lines +75 to +76
'instance_id': 'our_uuid',
'with_automatic_settings': True,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could filter out these keys, but it's maybe simpler to just send everything (as the PR does now)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's send everything.

@tronikos
Copy link
Member

tronikos commented Feb 4, 2025

Can you update the PR description to mention why you are doing this?

@MartinHjelmare MartinHjelmare marked this pull request as draft February 4, 2025 08:22
@emontnemery emontnemery marked this pull request as ready for review February 4, 2025 08:46
@piitaya
Copy link
Member

piitaya commented Feb 4, 2025

Front-end is approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants