Add support for add-on update type for backups in the UI #24044
Merged
+126
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
bramkragten
added
wait for backend
and removed
Backend Change Required
|
Backend is approved. |
bramkragten
reviewed
Feb 4, 2025
piitaya
force-pushed
the
addon_update_backup_type
branch
from
91831a4 to
80814b1
Compare
bramkragten
reviewed
Feb 4, 2025
bramkragten
reviewed
Feb 4, 2025
| @@ -340,7 +340,7 @@ export const computeBackupType = ( | |||
| if (backup.with_automatic_settings) { | |||
| return "automatic"; | |||
| } | |||
| if (isHassio && backup.extra_metadata?.["supervisor.addon_update"]) { | |||
| if (isHassio && backup.extra_metadata?.["supervisor.addon_update"] != null) { | |||
There was a problem hiding this comment.
I'd rather just check if the key is there honestly, or check it if truthy like before, but it is ok.
There was a problem hiding this comment.
Yeah but it would work if "supervisor.addon_update": null for some reason.
bramkragten
approved these changes
Feb 4, 2025
|
Backend PR is merged. |
bramkragten
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Add support for add-on update type for backups in the UI * Add type to backup detail page * Use new model * Fix detail page * Fix type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Display add-on update backup type for Hassio installs.
Core PR : home-assistant/core#137296
NEEDS: home-assistant/core#137296
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: