-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example automations to devolo Home Network #36101
base: current
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request enhance the documentation for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PLC_Device
participant Notification_System
participant WiFi_System
User->>PLC_Device: Check connected devices
PLC_Device-->>User: Return number of devices
alt Devices below threshold
User->>PLC_Device: Restart PLC device
end
User->>Notification_System: Monitor data rate
Notification_System-->>User: Data rate drops
alt Drop > 25%
User->>User: Notify user of data rate drop
end
User->>WiFi_System: Schedule guest Wi-Fi
WiFi_System-->>User: Enable guest Wi-Fi
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (5)
source/_integrations/devolo_home_network.markdown (5)
139-139
: Fix typo in the descriptionChange "sometime" to "sometimes" for correct grammar.
-PLC networks are sometime flaky. In order to restore a network's state it's sometimes a good idea +PLC networks are sometimes flaky. To restore a network's state it's sometimes a good idea🧰 Tools
🪛 LanguageTool
[style] ~139-~139: Consider a shorter alternative to avoid wordiness.
Context: ...iring PLC networks are sometime flaky. In order to restore a network's state it's sometime...(IN_ORDER_TO_PREMIUM)
143-162
: Make the automation example more genericThe automation example uses specific device names ("Alexandra") and IDs which may confuse users. Consider making it more generic and adding a comment explaining how users should replace these values with their own.
alias: PLC Feeder Restart description: "Restart device connected to the router if number of PLC devices is unexpected low" triggers: - trigger: numeric_state entity_id: - - sensor.alexandra_connected_plc_devices + - sensor.YOUR_DEVICE_connected_plc_devices # Replace with your device's sensor for: hours: 0 minutes: 10 seconds: 0 below: 3 conditions: [] actions: - - device_id: c38fe153e4a5b560995fd0a0850a5443 + - device_id: DEVICE_ID # Replace with your device's ID from the device page domain: button - entity_id: 5ccbb089c6208425aec3cb331dd0b716 + entity_id: ENTITY_ID # Replace with your restart button's entity ID type: press mode: single
172-195
: Improve example clarity and generalizationThe automation example could be more helpful with these improvements:
- Uses specific device names ("Nell", "Alexandra") and a specific notification service ("mobile_app_pixel_4a").
- The template condition could benefit from a comment explaining the calculation.
alias: PLC Data rate description: PLC Data rate dropped more than 25% triggers: - entity_id: - - sensor.nell_plc_downlink_phy_rate_alexandra - - sensor.nell_plc_uplink_phy_rate_alexandra + - sensor.YOUR_DEVICE_plc_downlink_phy_rate_TARGET # Replace with your device's sensors + - sensor.YOUR_DEVICE_plc_uplink_phy_rate_TARGET trigger: state conditions: - condition: template value_template: >- + # Checks if new value is less than 75% of previous value {{ not(0.75 < (trigger.to_state.state|float / trigger.from_state.state|float)) }} actions: - - action: notify.mobile_app_pixel_4a + - action: notify.YOUR_NOTIFICATION_SERVICE # Replace with your notification service metadata: {} data: message: >-
201-201
: Fix typo in the descriptionChange "of" to "off" in the description.
-You might want to expose your guest wifi only during the day but turn it of at night. +You might want to expose your guest wifi only during the day but turn it off at night.🧰 Tools
🪛 LanguageTool
[uncategorized] ~201-~201: “of” seems less likely than “off” (as in: go/turn off, off the coast).
Context: ...st wifi only during the day but turn it of at night. {% raw %} ```yaml alias: To...(AI_HYDRA_LEO_CP_OF_OFF)
205-220
: Make the automation example more genericThe automation example uses specific device and entity IDs which should be replaced with placeholders.
alias: Toggle Guest Wifi description: Turn Guest Wifi on and off triggers: - trigger: time at: "08:00:00" - trigger: time at: "17:00:00" conditions: [] actions: - type: toggle - device_id: ec24234d5d2daf35ff57d6162d2801ab - entity_id: 4c5ef9690593dc3c77079e4045558ac8 + device_id: DEVICE_ID # Replace with your device's ID + entity_id: ENTITY_ID # Replace with your guest WiFi switch's entity ID domain: switch mode: single
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/devolo_home_network.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/devolo_home_network.markdown
[style] ~139-~139: Consider a shorter alternative to avoid wordiness.
Context: ...iring PLC networks are sometime flaky. In order to restore a network's state it's sometime...
(IN_ORDER_TO_PREMIUM)
[uncategorized] ~201-~201: “of” seems less likely than “off” (as in: go/turn off, off the coast).
Context: ...st wifi only during the day but turn it of at night. {% raw %} ```yaml alias: To...
(AI_HYDRA_LEO_CP_OF_OFF)
🔇 Additional comments (2)
source/_integrations/devolo_home_network.markdown (2)
135-136
: LGTM!
The new section header follows documentation conventions and integrates well with the existing content.
135-223
: Overall documentation improvements look good!
The added automation examples provide valuable practical scenarios that will help users better understand and utilize the integration. The examples cover common use cases and follow a clear structure. After addressing the suggested improvements for generalization and fixing typos, this will be a great addition to the documentation.
🧰 Tools
🪛 LanguageTool
[style] ~139-~139: Consider a shorter alternative to avoid wordiness.
Context: ...iring PLC networks are sometime flaky. In order to restore a network's state it's sometime...
(IN_ORDER_TO_PREMIUM)
[uncategorized] ~201-~201: “of” seems less likely than “off” (as in: go/turn off, off the coast).
Context: ...st wifi only during the day but turn it of at night. {% raw %} ```yaml alias: To...
(AI_HYDRA_LEO_CP_OF_OFF)
Proposed change
Add example automation to fulfill the docs-examples quality scale requirement.
I looked at the imap integration on how to do this, however I'm not sure if the current format violates "The documentation pages should not be used as a collection or as a replacement of the blueprint exchange on the forums." If so, please advice how to propery fulfill the requirement.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
devolo Home Network
integration with example automations.These enhancements improve usability by providing practical scenarios for users to implement.