Poetry Setup for Enhanced Compatibility Across Python 3.8, 3.9, 3.10, 3.11, 3.12 #107
Conversation
…ython 3.9, 3.10, 3.11, 3.12, upgrade pylint version and cover new warning
…dom"' to extend compatibility across multiple python versions
ben9809
changed the title
There was a problem hiding this comment.
I understand that this file is not used anymore in the new workflow. The dependencies are handled directly with poetry, wouldn't it be better to remove this file?
There was a problem hiding this comment.
Yes, this file should be removed.
I also think we should remove .bumpversion.cfg
There was a problem hiding this comment.
I agree, it is also a good opportunity to add a release workflow.
There was a problem hiding this comment.
Why would we remove bumpversion?
It is used to easily update the version number in several locations, before we do a release.
| { include = "arbitragelab" } | ||
| ] | ||
|
|
||
| exclude = ["contrib", "docs", "tests"] |
There was a problem hiding this comment.
Is it contrib still in the repository root?
There was a problem hiding this comment.
It's not in the repo, I forgot to remove it.
|
@mripani Unfortunately the package cvxpy on Python 3.8 and 3.9 on macOS gives some problems, I installed it manually with the command |
There was a problem hiding this comment.
Why would we remove bumpversion?
It is used to easily update the version number in several locations, before we do a release.
|
Thank you so very much! |
Purpose
This pull request aims to set up Poetry for dependency management in the project. The integration of Poetry is intended to streamline our development process by simplifying dependency management and packaging.
Approach
The integration of Poetry replaces the previous dependency management system. By utilizing Poetry, we can define project dependencies in a more structured pyproject.toml file instead of the traditional requirements.txt. This change addresses the need for a more robust and easy-to-manage dependency configuration. The pyproject.toml file has been created with all the necessary dependencies. Some dependencies have been upgraded to a new version to ensure no conflict between each other, this triggered new warnings that lead to a refactor of some files.
A new workflow setup has been updated, to fully leverage poetry capabilities.
Tests for New Behavior
Major Changes
.coveragerc-> Enable parallel mode when executing coverage.github/workflows/python-tests.yaml-> Cover all python versions from 3.8.pylintrc-> Due to an upgrade of pylint to cover multiple Python versions, some pylint setting have been deprecated, so they have been removed from the configuration filearbitragelab/__init__.py-> redefine imports to comply with the new warning generated by the new pylint versionarbitragelab/ml_approach/optics_dbscan_pairs_clustering.py-> To support Python 3.12 a new version of sklearn is needed. Since the class TSNE in the new version has different default parameters, it has been adapted to reflect the behavior of the previous versions. Here is the link: https://scikit-learn.org/stable/modules/generated/sklearn.manifold.TSNE.htmldocs/source/conf.py-> logo fixtests/test_neural_networks.py,tests/test_spread_modeling_helper.py-> adapt imports and 'Session configuration' to new tensorflow version compatible across multiple python versionsAll the rest of the files changed have been subjected to minor changed mostly to comply with the new pylint version
Checklist
None
Learning
None