Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table a11y fix #1505

Merged
merged 6 commits into from
Aug 21, 2023
Merged

Table a11y fix #1505

merged 6 commits into from
Aug 21, 2023

Conversation

xman343
Copy link
Contributor

@xman343 xman343 commented Aug 17, 2023

Changes

#1148 - Table failing due to subrow expand button failing button-name rule.

*Passing solution: Implemented aria-label for subrow expand button.

Testing

Testing will be conducted through the Cypress web a11y script. Any breaking changes will be evaluated through unit testing & visual tests.

I am also reading the examples with NVDA to assess their screen reader compatibility.

Docs

N/A

@xman343 xman343 self-assigned this Aug 17, 2023
@xman343 xman343 added the a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc) label Aug 17, 2023
@xman343
Copy link
Contributor Author

xman343 commented Aug 18, 2023

Switched from using label to aria-label because the former caused two unit tests (should render sub-rows and handle expansions and should render filtered sub-rows) to fail. Both solutions pass the Cypress a11y evaluation, and both are screen-reader legible. I'll keep this solution unless there is one that is supposed to be better.

@xman343 xman343 marked this pull request as ready for review August 18, 2023 17:26
@xman343 xman343 requested review from a team as code owners August 18, 2023 17:26
@xman343 xman343 requested review from mayank99 and r100-stack and removed request for a team August 18, 2023 17:26
@mayank99 mayank99 merged commit 1ca0a6a into dev Aug 21, 2023
@mayank99 mayank99 deleted the xander/table-a11y-fix branch August 21, 2023 14:11
@imodeljs-admin imodeljs-admin mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants