Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table a11y fix #1505

Merged
merged 6 commits into from
Aug 21, 2023
Merged

Table a11y fix #1505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40372c4
label added to expand sub row button
xman343 Aug 17, 2023
8fd4938
changeset added
xman343 Aug 17, 2023
562d037
Merge branch 'dev' into xander/table-a11y-fix
xman343 Aug 17, 2023
41137d6
label changd to aria-label
xman343 Aug 18, 2023
f6d1b81
aria expanded prop added
xman343 Aug 18, 2023
415e897
Merge branch 'dev' into xander/table-a11y-fix
mayank99 Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stale-bees-turn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@itwin/itwinui-react': patch
---

Gave accessible label to the sub-row toggle in <Table>.
2 changes: 2 additions & 0 deletions packages/itwinui-react/src/core/Table/SubRowExpander.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ export const SubRowExpander = <T extends Record<string, unknown>>(
expanderCell(cellProps)
) : (
<IconButton
aria-label='Toggle sub row'
mayank99 marked this conversation as resolved.
Show resolved Hide resolved
aria-expanded={cell.row.isExpanded ? 'true' : 'false'}
style={{
marginInlineEnd:
density === 'default' || density === undefined ? 8 : 4,
Expand Down