fix Table columnOrder resetting incorrectly
#1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
r100-stack and
Ben-Pusey-Bentley
and removed request for
a team
r100-stack
approved these changes
Mar 6, 2024
mayank99
changed the title
columnOrder resetting incorrectly
mayank99
commented
Mar 6, 2024
Comment on lines
718
to
726
| React.useEffect(() => { | ||
| // Check if columns have changed (by value) | ||
| if (JSON.stringify(lastPassedColumns.current) !== JSON.stringify(columns)) { | ||
| if ( | ||
| lastPassedColumns.current.length > 0 && | ||
| JSON.stringify(lastPassedColumns.current) !== JSON.stringify(columns) | ||
| ) { | ||
| instance.setColumnOrder([]); | ||
| } | ||
| lastPassedColumns.current = columns; |
There was a problem hiding this comment.
Some comments for future:
-
We should try to avoid stringifying columns like this. It can be expensive and error-prone. In our new Table we could require always passing an id, or find a way to compare the internal ids.
-
We should maybe create a hook for this "previous state" pattern.
function usePreviousState<T>(state: T, onChange: () => void): React.Ref<T>;
There was a problem hiding this comment.
Sounds good, linked this comment in #1144.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1899.
The root cause was that the initial value of
lastPassedColumnsis[]so it was always resetting the columns.[]is never valid so I've added a simple check for it.Testing
Tested in playground (using linked sandbox) and added unit test.
Docs
N/A