-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable transform layer for images where it is not needed (to speed-up image processing) #7449
Disable transform layer for images where it is not needed (to speed-up image processing) #7449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru , I left few comments here. Could you please take a look at them?
Hi @Districh-ru , could you please update the description to specify the scope of testing? At least to verify that we don't break any rendering by these changes. |
Hi, @ihhub, a short description is added. |
Hi, @drevoborod, could you please test this PR when you have time. |
Testing completed, didn't find any issues. All mentioned cases were checked plus several extra. |
@Districh-ru , thank you so much for this improvement! |
This PR is a part of #7233
This PR disables
transform()
layer for images that have no transparent (or shadow/bright transform) pixels:Doing this will save some computation resources while processing these images: no operations with the transform layer would be performed.
This PR changes properties of many loaded images so to test it is good to check rendering of maps, in castles, battlefield, dialogs for possible transparency bugs (e.g. blacked image parts in place of transparency of sprites).
As the changes are the same for the same type of images the check may include viewing each type of render, e.g.: