Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing request body #789

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle missing request body #789

wants to merge 2 commits into from

Conversation

amh4r
Copy link
Contributor

@amh4r amh4r commented Dec 22, 2024

Summary

Explicitly handle the missing request body case. This can happen when the app doesn't have request body parsing middleware (e.g. express.json).

Before these changes, the user would see an unhelpful "invalid signature" error:
image

Checklist

  • Added a docs PR that references this PR
  • Added unit/integration tests
  • Added changesets if applicable

@amh4r amh4r requested a review from jpwilliams December 22, 2024 18:40
Copy link

changeset-bot bot commented Dec 22, 2024

🦋 Changeset detected

Latest commit: 063832f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 inngest Affects the `inngest` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants