Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing request body #789

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle missing request body #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05d6570
Handle missing request body
amh4r Dec 22, 2024
063832f
Add changeset
amh4r Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silent-carrots-develop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"inngest": patch
---

Better handle missing request body
16 changes: 16 additions & 0 deletions packages/inngest/src/components/InngestCommHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,22 @@ export class InngestCommHandler<
}),
]);

// This is when the request body is completely missing; it does not
// include an empty body. This commonly happens when the HTTP framework
// doesn't have body parsing middleware.
const isMissingBody = body === undefined;

if (isMissingBody) {
this.log(
"error",
"Missing body, possibly due to missing request body middleware"
);
return {
headers: getInngestHeaders(),
status: 500,
};
}

const signatureValidation = this.validateSignature(signature, body);

const headersToForwardP = Promise.all(headerPromises).then(
Expand Down
Loading