chore(ci): package-lock is updated from separate job #28697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
requested review from
sean-perkins
and removed request for
a team
averyjohnston
approved these changes
Dec 19, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
In #28697 I moved the package-lock work to its own step to lets us re-run that if it fails. However, I forgot to checkout the project files in that step, so there was no `package-lock.json` file to update [resulting in an error](https://github.com/ionic-team/ionic-framework/actions/runs/7398703880/job/20128761433).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After each release, we need to update the local
package-lock.jsondependencies. We do this via anpm install --package-lock-onlycommand. However, this command can fail for reasons such as a connection timeout. When this happens, the package-lock files do not get updated.The problem is this action is also done in the same job as generating the changelog and creating the GitHub release. This operations cannot be re-done. As a result, we cannot simply re-run this job and try updating the package-lock files again.
This PR changes the workflow to split the package-lock update out to its own job. In the event that this job fails, we can re-run only this job and leave the other jobs untouched.