Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved parameters to
nextflow.config
.Details of the code here:
https://github.com/evanbiederstedt/clockwork/blob/feature/revise_NF_params/nextflow.config#L9-L16
Parameters I found here:
https://github.com/evanbiederstedt/clockwork/blob/feature/revise_NF_params/nextflow.config#L18-L51
Note:
It looks like all parameter names are the unique, except for
max_forks
:It's 20 here:
https://github.com/iqbal-lab-org/clockwork/blob/master/nextflow/fake_remove_contam.nf#L5
Here it's 100:
https://github.com/iqbal-lab-org/clockwork/blob/master/nextflow/generic_pipeline.nf#L6
It may be best to rename the variable for one of these.
Added default trace settings here, with fields I find useful:
https://github.com/evanbiederstedt/clockwork/blob/feature/revise_NF_params/nextflow.config#L54-L58
Added default timeline, report, and DAG graphic.
https://github.com/evanbiederstedt/clockwork/blob/feature/revise_NF_params/nextflow.config#L60-L73
You might want to remove the DAG graphic if your pipeline is stable---it will be the same thing after each pipeline run.
Also, you'll noticed I added shebangs to the NF scripts---feel free to remove if superfluous :)