Fixed visual prims handling during texture randomization. #2476
+29
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
KumoLiu
requested review from
jsmith-bdai,
kellyguo11 and
Mayankm96
as code owners
Mayankm96
reviewed
May 14, 2025
| @@ -1188,8 +1188,25 @@ def __init__(self, cfg: EventTermCfg, env: ManagerBasedEnv): | |||
| body_names_regex = ".*" | |||
|
|
|||
| # create the affected prim path | |||
| # TODO: Remove the hard-coded "/visuals" part. | |||
| prim_path = f"{asset.cfg.prim_path}/{body_names_regex}/visuals" | |||
| # Check if the pattern with '/visuals' yields results when matching `body_names_regex`. | |||
There was a problem hiding this comment.
Can you please modify the unit test for this function to showcase the cases that's getting handled here?
There was a problem hiding this comment.
Hi @Mayankm96, Thank you for the suggestion. The change I'm implementing aims to handle cases where the visual prim path does not end with visuals. I've checked the assets used in the test cases, and all of them end with visuals.
In my use case, the table prim path I'm working with is something like /World/envs/env_./Table/.. I haven't found any assets that could show this benefit in the test file. Do you have any suggestions?
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed potential issues in :func:
~isaaclab.envs.mdp.events.randomize_visual_texture_materialrelated to handling visual prims during texture randomization.Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there