Allows for custom TerrainGenerator without modifications of the TerrainImporter
#2487
+118
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
reviewed
May 14, 2025
| @@ -108,6 +113,8 @@ def __init__(self, cfg: TerrainGeneratorCfg, device: str = "cpu"): | |||
| self.device = device | |||
|
|
|||
| # set common values to all sub-terrains config | |||
| from .height_field import HfTerrainBaseCfg # prevent circular import | |||
There was a problem hiding this comment.
Hm how is the circular import happening? Is there a smarter way to avoid this?
There was a problem hiding this comment.
I am not sure because we do a instance checking of a configclass, this usually doesn't work. But open for suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
TerrainGeneratorclass is hardcoded in theTerrainImporter. This class resolves this issue and allows for custom implementations.TODO: adjust changelog and versoning after review
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there