Skip to content

Add IMU projected_gravity_b and IMU computation speed optimizations #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

jtigue-bdai
Copy link
Collaborator

@jtigue-bdai jtigue-bdai commented May 16, 2025

Description

This PR adds projected_gravity_b data stream as well as speeding up computation by during batch rotating of all data streams to base frame in one computation rather than each data stream separately.

This PR is dependant on PR 2129 and should not be merged until that PR is merged.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Mayankm96
Copy link
Contributor

Can we keep quat rotate and quat apply changes to another MR? Otherwise it is getting burried here under "IMU changes" which isn't correct.

@jtigue-bdai
Copy link
Collaborator Author

Can we keep quat rotate and quat apply changes to another MR? Otherwise it is getting burried here under "IMU changes" which isn't correct.

I can, I was mainly trying to utilize the quat_apply_inverse function which was introduced in the other PR. If we want to get this in sooner I can switch to quat_apply(quat_inv(quat)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants