Fix memory leak in SDF calculation - warp doesn't free memory #2680
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
reviewed
Jun 15, 2025
| sdf_reward = -torch.log(sdf_reward) | ||
|
|
||
| gp.collect() # Force garbage collection to free memory |
There was a problem hiding this comment.
Should this be gc.collect()?
There was a problem hiding this comment.
Yes - I will fix this typo
Thanks!
|
@yijieg could you help review this one as well? |
|
Hi @kellyguo11 , this change looks good to me. It helps save memory but does not affect the reward we calculated, so it will not affect the learning performance. |
Fix typo Signed-off-by: David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to Matteo Grimaldi, Saleh Nabi and Wonju Lee for identifying the source of this memory leak.
Add garbage collector calls since warp doesn't handle well the free memory.
Fixes #2679
Type of change
Screenshots
Before this change - the experiment hasn't been completed on 64GB RAM machines.
After this change it requires less than 12GB RAM.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there