Update documentation on pytorch multi gpu setup #2687
+52
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Omar-Nvidia
requested review from
jsmith-bdai,
kellyguo11 and
Mayankm96
as code owners
kellyguo11
reviewed
Jun 16, 2025
| For a deeper dive into how Torchrun works, checkout | ||
| `PyTorch Docs: DistributedDataParallel - Internal Design <https://pytorch.org/docs/stable/notes/ddp.html#internal-design>`_. | ||
|
|
||
| Jax Implementation |
There was a problem hiding this comment.
may be good to add a note here that only SKRL supports Jax
There was a problem hiding this comment.
Done, i added a call out that JAX is only for SKRL.
| The key components in this setup are: | ||
|
|
||
| * **Torchrun**: Handles process spawning, communication, and gradient synchronization. | ||
| * **RL Games**: The reinforcement learning framework that runs the actual training algorithm. |
There was a problem hiding this comment.
multi-GPU is not specific to RL Games, SKRL and RSL RL both support it as well. we can maybe rename this to RL Library
There was a problem hiding this comment.
looks like it's still saying "RL Games"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Multi GPU documentation to include more information about how we integrate with Pytorch and include more documentation links.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there