issue-157-autoReload-using-original-values #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daraclare this makes sense, i'll try to get this tested and merged within the following days. Thank you. |
|
@daraclare i'm sorry abt the delays on this, I'm struggling with some CORS errors when trying to test this locally:
This is also happening with |
|
LGTM |
|
This has been pushed to npm. See v0.21.0. Thank you. |
sectsect
added a commit
to sectsect/react-dfp
that referenced
this pull request
Apr 18, 2022
…nauati#226)" This reverts commit ade4f3b.
sectsect
added a commit
to sectsect/react-dfp
that referenced
this pull request
May 31, 2022
…esh (jaanauati#226)"" This reverts commit 5a91286.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #157
The targeting values were set correctly, but not updated correctly for client side rendering, only worked with a full page refresh.
The
registeredSlotswere sent on refresh with the original values rather than the new targeting values.Also, the DFPManager.refresh was refreshing using
registeredSlots[slotId].gptSlotrather thanregisteredSlots[slotId].slotId@jaanauati could you let me know if you're happy for this to go ahead? Thanks!