Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "Get Distribution Export" polling logic #1047

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

eyalbe4
Copy link
Contributor

@eyalbe4 eyalbe4 commented Nov 25, 2024

Modify the logic of the code that waits for the distribution export to finish.
Instead of waiting of the a completion signal from the API, we're also waiting for the relative path to not be "" or "/"

@eyalbe4 eyalbe4 added bug Something isn't working safe to test Approve running integration tests on a pull request labels Nov 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (eyalbe4)[https://github.com/eyalbe4]
@eyalb4doc
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Nov 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 28, 2024
@eyalbe4 eyalbe4 merged commit f7afbb4 into jfrog:dev Nov 28, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants