Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "Get Distribution Export" polling logic #1047

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Fix the "Get Distribution Export" polling logic #1047

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21a01cb
Fix Get Distribution Export
eyalb4doc Nov 25, 2024
96960a0
Merge branch 'dev' into improve-distribution-polling
eyalbe4 Nov 26, 2024
fbbeae3
Merge branch 'dev' into improve-distribution-polling
eyalbe4 Nov 28, 2024
c3acb18
Also added a check for the download URL
eyalb4doc Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lifecycle/services/export.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ package services
import (
"encoding/json"
"fmt"
"path"

"github.com/jfrog/jfrog-client-go/utils/errorutils"
"github.com/jfrog/jfrog-client-go/utils/io/httputils"
"github.com/jfrog/jfrog-client-go/utils/log"
"path"
)

const (
Expand Down Expand Up @@ -101,8 +102,14 @@ func (rbs *ReleaseBundlesService) waitForExport(rbDetails ReleaseBundleDetails,
switch response.Status {
case ExportProcessing:
return false, nil, nil
case ExportCompleted, ExportFailed:
case ExportFailed:
return true, responseBody, nil
case ExportCompleted:
if response.RelativeUrl != "" && response.RelativeUrl != "/" &&
response.DownloadUrl != "" {
return true, responseBody, nil
}
return false, nil, nil
default:
return true, nil, errorutils.CheckErrorf("received unexpected status: '%s'", response.Status)
}
Expand Down
Loading