Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS2 support and remove obsolete tools #40

Merged
merged 10 commits into from
Feb 16, 2024

Conversation

gergondet
Copy link
Member

The RViZ panel is ported to ROS2 (kudos to @arntanguy for the hard work, I mostly adapted his branch here ^^)

The repo builds both with ROS1 and ROS2. Packaging is also done on a single branch.

Obsolete tools removal

mc_convex_visualization/mc_rtc_ticker/mc_surfaces_visualization have native versions of the same name

mc_log_visualization is superseeded by the Replay functionalities

We keep the mc_rtc_ticker package for the launch file it provides which is widely used: roslaunch mc_rtc_ticker display.launch

This is also adapted to work on ros2: ros2 launch mc_rtc_ticker display.launch

mc_convex_visualization/mc_rtc_ticker/mc_surfaces_visualization have
native versions of the same name

mc_log_visualization is superseeded by the Replay functionalities

We keep the mc_rtc_ticker package for the launch file it provides and is
widely used: `roslaunch mc_rtc_ticker display.launch`
- Add relevant COLCON_IGNORE file
- Remove direct references to ROS types
- Add new launch/plugin files for ROS2

All that is left should be to change code to compile with ROS2
@gergondet gergondet requested a review from arntanguy February 16, 2024 10:11
@gergondet gergondet merged commit cdd045c into jrl-umi3218:master Feb 16, 2024
9 checks passed
@arntanguy
Copy link
Collaborator

Thanks @gergondet for finalizing this!
It's great that you found a way to support both catkin and colcon!

@arntanguy arntanguy mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants