-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Fix for issue #21118: inconsistent behavior across callbacks #21275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix for issue #21118: inconsistent behavior across callbacks #21275
Conversation
…d logic used in EarlyStopping.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21275 +/- ##
=======================================
Coverage 82.57% 82.57%
=======================================
Files 564 564
Lines 54629 54649 +20
Branches 8495 8504 +9
=======================================
+ Hits 45108 45125 +17
- Misses 7432 7434 +2
- Partials 2089 2090 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
@@ -197,6 +183,44 @@ def __init__( | |||
f"filepath={self.filepath}" | |||
) | |||
|
|||
def _set_monitor_op(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we refactor this logic into a standalone function that we could reuse across all callbacks that need this functionality?
#21118