Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: remove useless stateInformer.impl StateInformer interface #2286

Conversation

j4ckstraw
Copy link
Contributor

Ⅰ. Describe what this PR does

clean up stateInformer.impl StateInformer interface
use api.StateInformer interface instead

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@j4ckstraw j4ckstraw changed the title chore: remove useless stateInformer.impl StateInformer interface koordlet: remove useless stateInformer.impl StateInformer interface Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.04%. Comparing base (13a7107) to head (87bdcdd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2286      +/-   ##
==========================================
- Coverage   66.04%   66.04%   -0.01%     
==========================================
  Files         454      454              
  Lines       53438    53438              
==========================================
- Hits        35295    35292       -3     
- Misses      15601    15605       +4     
+ Partials     2542     2541       -1     
Flag Coverage Δ
unittests 66.04% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j4ckstraw j4ckstraw force-pushed the fix/cleanUp-stateInformer-interface branch from bf13e39 to 87bdcdd Compare December 2, 2024 06:34
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot merged commit d06699e into koordinator-sh:main Dec 2, 2024
22 checks passed
@j4ckstraw j4ckstraw deleted the fix/cleanUp-stateInformer-interface branch December 2, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants