Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add Go section to install clusterctl #11464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sivchari
Copy link
Member

What this PR does / why we need it:

I added the Go section to install clusterctl via go install.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 22, 2024
@sivchari
Copy link
Member Author

Ah, sorry. Presumably, we can't embed the some versions via ldflags option if we use go install.
So, this PR might not be necessary. Or, do we need to deal with the way to use go install ?

@chrischdi
Copy link
Member

Ah, sorry. Presumably, we can't embed the some versions via ldflags option if we use go install. So, this PR might not be necessary. Or, do we need to deal with the way to use go install ?

An alternative would be to make clusterctl not fail when the ld flags have not been set. Afaik they are only used for the version subcommand (which should be okay) and as post run to check for new versions.

@sivchari
Copy link
Member Author

I think it's prefer the way you propose. So I'd open the issue to discuss about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants