Add Core Functionality With Some Extras #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmckeon
approved these changes
May 15, 2024
There was a problem hiding this comment.
This is awesome! Nice job. Next challenge for you: How can you refactor this to make it more readable? Is there any duplication that can be removed? Can you rename things to make them more readable? Try to get each function down to 10 lines at most for extra fun.
stephenmckeon
approved these changes
May 16, 2024
| @@ -4,24 +4,34 @@ | |||
| <meta charset="UTF-8"> | |||
| <title>Flatiron Task Lister</title> | |||
| <link rel="stylesheet" href="./style.css"> | |||
| <script defer src="./src/index.js"></script> | |||
There was a problem hiding this comment.
What does the defer attribute do?
There was a problem hiding this comment.
It defers loading the script to after the DOM has loaded. I like placing the script tag up top.
Screen.Recording.2024-05-16.at.2.57.51.PM.movVideo of current functionality. Needs more code refactoring to slim down functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To-Do app is able to create, and delete tasks. Also empty input field will not result in creating blank tasks.