-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Core Functionality With Some Extras #8
Open
yuriyivanenko
wants to merge
6
commits into
learn-co-curriculum:master
Choose a base branch
from
yuriyivanenko:feature_branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a4be9fc
Add create/delete functionality
yuriyivanenko 85cbad9
Refactor code
yuriyivanenko db0b87f
ALOT of changes
yuriyivanenko b30d60b
Full CRUD capability added
yuriyivanenko 7b1ba6d
Move table-row creation into seperate function
yuriyivanenko 84b0a5f
Move reset of App after PATCH into seperate function
yuriyivanenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,177 @@ | ||
| document.addEventListener("DOMContentLoaded", () => { | ||
| // your code here | ||
| }); | ||
| const form = document.querySelector('#create-task-form') | ||
| const submitButton = document.querySelector("#create-task-form input[type='submit']") | ||
|
|
||
| const createNewTask = (e) => { | ||
| e.preventDefault() | ||
| const taskText = e.target['new-task-description'].value | ||
| const taskPriority = e.target['new-task-priority'].value | ||
| if(taskText !== '' && taskPriority !== ''){ | ||
| handleTaskPOST(taskText, taskPriority).then(data => { | ||
| const tr = document.createElement('tr') | ||
| tr.id = data.id | ||
| const td1 = document.createElement('td') | ||
| const td2 = document.createElement('td') | ||
| const td3 = document.createElement('td') | ||
| const editBtn = createEditButton(data.id); | ||
| const deleteBtn = createDeleteButton(data.id) | ||
| tr.className = taskPriority | ||
| td1.textContent = taskText | ||
| td2.appendChild(deleteBtn) | ||
| td3.appendChild(editBtn) | ||
| tr.appendChild(td1) | ||
| tr.appendChild(td2) | ||
| tr.appendChild(td3) | ||
| document.querySelector('#task-table').appendChild(tr) | ||
| document.querySelector("#new-task-description").value = '' | ||
| document.querySelector("#task-priority").value = '' | ||
| //form.reset() | ||
| }) | ||
| .catch(error => { | ||
| console.log(error) | ||
| }) | ||
|
|
||
| } | ||
| } | ||
|
|
||
| //Create edit button and return | ||
| const createEditButton = (id) => { | ||
| const editBtn = document.createElement('button') | ||
| editBtn.style.marginLeft = '20px' | ||
| editBtn.textContent = 'Edit' | ||
| editBtn.className = 'btn' | ||
| editBtn.setAttribute('task-id',id) | ||
| editBtn.addEventListener('click', editTask) | ||
| return editBtn | ||
| } | ||
|
|
||
| const createDeleteButton = (id) => { | ||
| const btn = document.createElement('button') | ||
| btn.style.marginLeft = '20px' | ||
| btn.textContent = 'Delete' | ||
| btn.className = 'btn' | ||
| btn.addEventListener('click', handleTaskDELETE) | ||
| btn.setAttribute('task-id',id) | ||
| return btn | ||
| } | ||
|
|
||
|
|
||
| const handleTaskPOST = (taskText, taskPriority) => { | ||
| return fetch('http://localhost:3000/tasks',{ | ||
| method: "POST", | ||
| headers: { | ||
| 'Content-Type' : 'application/json' | ||
| }, | ||
| body: JSON.stringify({ | ||
| task: taskText, | ||
| priority: taskPriority | ||
| }) | ||
| }) | ||
| .then(res => res.json()) | ||
| .then(data => data) | ||
| .catch(error => { | ||
| alert('Ooops, something went wrong when trying to write data to the server') | ||
| console.log(error) | ||
| }) | ||
| } | ||
|
|
||
| const handleTaskDELETE = (e) => { | ||
| const id = e.target.attributes['task-id'].value | ||
| const task = e.target.closest('tr').firstChild.textContent | ||
| fetch(`http://localhost:3000/tasks/${id}`,{ | ||
| method: 'DELETE', | ||
| }) | ||
| .then(res => res.json()) | ||
| .then(data => { | ||
| e.target.closest('tr').remove() | ||
| }) | ||
| .catch(error => { | ||
| alert(`Ooops, something went wrong when trying to delete task: ${task}`) | ||
| console.log(error) | ||
| }) | ||
| } | ||
|
|
||
| const handleTaskPATCH = (e) => { | ||
| e.preventDefault() | ||
| const taskText = e.target['new-task-description'].value | ||
| const taskPriority = e.target['new-task-priority'].value | ||
| id = submitButton.attributes['task-id'].value | ||
| fetch(`http://localhost:3000/tasks/${id}`,{ | ||
| method: "PATCH", | ||
| headers: { | ||
| 'Content-Type' : 'application/json' | ||
| }, | ||
| body: JSON.stringify({ | ||
| task: taskText, | ||
| priority: taskPriority | ||
| }) | ||
| }) | ||
| .then(res => res.json()) | ||
| .then(data => { | ||
| //initApp(); | ||
| document.querySelector("#new-task-description").value = '' | ||
| document.querySelector("#task-priority").value = '' | ||
| submitButton.className = 'btn' | ||
| submitButton.removeAttribute('task-id') | ||
| submitButton.value = 'Create New Task' | ||
| form.removeEventListener('submit', handleTaskPATCH) | ||
| form.addEventListener('submit',createNewTask) | ||
| document.querySelectorAll('tr').forEach(tr => { | ||
| tr.remove() | ||
| }) | ||
| initApp() | ||
| }) | ||
| .catch(error => { | ||
| alert(`Something went wrong while trying to update task: ${taskText}`) | ||
| console.log(error) | ||
| }) | ||
| } | ||
|
|
||
| const editTask = (e) => { | ||
| const task = e.target.closest('tr').firstChild.textContent | ||
| const priority = e.target.closest('tr').className | ||
| const id = e.target.attributes['task-id'].value | ||
| // console.log(id) | ||
| document.querySelector("#new-task-description").value = task | ||
| document.querySelector("#task-priority").value = priority | ||
| submitButton.className = 'editBtn' | ||
| submitButton.value = 'Edit Task' | ||
| submitButton.setAttribute('task-id',id) | ||
| form.removeEventListener('submit', createNewTask) | ||
| form.addEventListener('submit',handleTaskPATCH) | ||
| } | ||
|
|
||
| const renderTasks = (body) => { | ||
| document.querySelector("#new-task-description").value = '' | ||
| document.querySelector("#task-priority").value = '' | ||
| document.querySelectorAll('tr').forEach(tr => console.log(tr)) | ||
| body.forEach(item => { | ||
| const tr = document.createElement('tr') | ||
| const td1 = document.createElement('td') | ||
| const td2 = document.createElement('td') | ||
| const td3 = document.createElement('td') | ||
| const editBtn = createEditButton(item.id) | ||
| const deleteBtn = createDeleteButton(item.id) | ||
| tr.id = item.id | ||
| tr.className = item.priority | ||
| td1.textContent = item.task | ||
| td2.appendChild(deleteBtn) | ||
| td3.appendChild(editBtn) | ||
| tr.appendChild(td1) | ||
| tr.appendChild(td2) | ||
| tr.appendChild(td3) | ||
| document.querySelector('#task-table').appendChild(tr) | ||
| }) | ||
| } | ||
|
|
||
| const initApp = () => { | ||
| fetch('http://localhost:3000/tasks') | ||
| .then(res => res.json()) | ||
| .then(body => renderTasks(body)) | ||
| .catch(error => { | ||
| alert('Ooops, looks like something went wrong when trying to retrieve tasks from db.json') | ||
| console.log(error) | ||
| }) | ||
| } | ||
|
|
||
| form.addEventListener('submit', createNewTask) | ||
| document.addEventListener('DOMContentLoaded', initApp) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the
deferattribute do?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It defers loading the script to after the DOM has loaded. I like placing the script tag up top.