Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Invalid prop" error #13125

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Feb 27, 2025

Summary

Fixes "Invalid prop: custom validator check failed for prop 'value' error by removing what appears to be, as best as I can say, the obsolete 'channels' object property that is not passed into and neither used in the component.

References

Fixes #13058

Reviewer guidance

Note there is The computed property "PageNames" is already defined in data warning in the browser console - will fix in another PR.

QA

  • Go to Coach -> Lesson -> Manage resources -> rewrite /lessons to /lessonstemp URL and in the "Manage lesson resources", click on the Search button (make sure you see the new experience)

Screenshot from 2025-02-27 19-26-38

  • Check that there is no "Invalid prop" error in the browser console
  • There should be no regressions in the side panel

Code

  • 'channels' is really not needed anywhere?

by removing the obsolete 'channels' object property
that is not passed into and neither used in the component.
@MisRob MisRob added the TODO: needs review Waiting for review label Feb 27, 2025
@radinamatic
Copy link
Member

Specific Invalid prop: custom validator check failed for prop 'value' error seems to have been fixed, tested in Chrome and Firefox on Ubuntu. Some other errors and warns are present in the console, but no UX regressions.

Firefox Chrome
ff chrome

Misaligned category icons are reported elsewhere, I believe...

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you! 💯 🎉 :shipit:

@rtibbles rtibbles merged commit b7e66a2 into learningequality:develop Mar 3, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Prop in Search Filters
3 participants