test: dht #7
Merged
test: dht #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
force-pushed
the
test/dht
branch
2 times, most recently
from
c14b887 to
dc0898a
Compare
vasco-santos
force-pushed
the
test/dht
branch
5 times, most recently
from
3b5c9f2 to
280fdfb
Compare
|
As discussed with @jacobheun and @bigs , we will move forward with this PR skipping the |
jacobheun
approved these changes
Mar 29, 2019
test/dht/content-routing/go2go.js
Outdated
| }) | ||
|
|
||
| it('go peer to go peer', async function () { | ||
| this.timeout(30 * 1000) |
There was a problem hiding this comment.
We should drop all these timeouts in the content routing. CI is showing sub 1 second test runs, so the standard timeout should be more than fine. This will just make testing take longer when things aren't behaving properly.
test/dht/peer-routing/go2go.js
Outdated
| }) | ||
|
|
||
| it('go peer to go peer', async function () { | ||
| this.timeout(10 * 1000) |
There was a problem hiding this comment.
peer routing tests also show well under 5seconds, we should be able to drop the timeouts in all the peer routing tests.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added interop tests for dht regarding:
content-routingcontent-fetchingpeer-routingNeeds:
libp2p/js-libp2p-daemon-client#fix/dht-find-providers(do not know why this only works with that change though)