Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ledger connector to support chain change #191

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Oct 28, 2024

  • all packages now require viem and wagmi at floating version to prevent package dup
  • rework demo app to match widget
  • add switch chain to demo app
  • add chain switch to hardware ledger connector
  • change set & update versions

Testing notes

Only ledger hardware connector chainSwitch functionality is touched. But also there is a a chain switch selector in demo page( in address modal) that can be used to trigger chain change in any wallet like MM.
Please check that changing chain works correctly with ledger hardware, and tx get send to ledger device with correct chain id and address.

@Jeday Jeday requested a review from a team as a code owner October 28, 2024 09:39
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 42e182d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@alx-khramov alx-khramov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks okay, but changeset and changeset version will be needed before releasing. Also, blocked by #183

@Jeday Jeday requested a review from alx-khramov November 18, 2024 09:42
alx-khramov
alx-khramov previously approved these changes Nov 18, 2024
@Jeday Jeday merged commit 1bcd7a3 into main Nov 19, 2024
1 check passed
@Jeday Jeday deleted the feature/si-1640-update-llhardware-ledger-connector branch November 19, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants