Skip to content

Hold times for successful payments #3801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

joostjager
Copy link
Contributor

@joostjager joostjager commented May 26, 2025

Apply the hold time reporting mechanism as implemented in #2256 to the success case.

@ldk-reviews-bot
Copy link

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@joostjager joostjager changed the title Successful payment hold times Hold times for successful payments May 26, 2025
@joostjager joostjager force-pushed the fulfill-hold-times branch 5 times, most recently from 7766555 to b4c1452 Compare May 27, 2025 08:54
@joostjager joostjager force-pushed the fulfill-hold-times branch 2 times, most recently from badc803 to e913312 Compare May 27, 2025 09:52
@joostjager joostjager force-pushed the fulfill-hold-times branch from e913312 to 69a99b4 Compare May 27, 2025 11:53
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 98.50746% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.58%. Comparing base (22908ab) to head (69a99b4).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 93.10% 1 Missing and 1 partial ⚠️
lightning/src/ln/onion_utils.rs 99.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3801      +/-   ##
==========================================
+ Coverage   89.81%   90.58%   +0.76%     
==========================================
  Files         159      159              
  Lines      128672   134584    +5912     
  Branches   128672   134584    +5912     
==========================================
+ Hits       115571   121912    +6341     
+ Misses      10428    10067     -361     
+ Partials     2673     2605      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants