-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cache Resolver] Implement relative web path resolver #1059
Conversation
# Conflicts: # Tests/Imagine/Cache/Resolver/WebPathResolverTest.php
It would better to register a new resolver for that, instead of adding a bool flag. |
Once we work out all the code implementation details (which I'll provide my comments on shortly, once I get a chance to review everything), be advised that we only accept PRs that includes documentation. You should add the appropriate files in the |
@nmuntyanov please resolve conflicts on this PR, so it could be processed further. |
# Conflicts: # Tests/DependencyInjection/ConfigurationTest.php # Tests/DependencyInjection/Factory/Resolver/WebPathResolverFactoryTest.php # Tests/DependencyInjection/LiipImagineExtensionTest.php # Tests/Imagine/Cache/Resolver/WebPathResolverTest.php
Resolved |
Tests were fixed here: #1087 |
@robfrawley check this PR please. |
since default branch was changed to |
@maximgubar updated |
Any news regarding this PR? @maximgubar @nmuntyanov |
Any news? @nmuntyanov |
Replaced by #1233 |
#| Q | A
| --- | ---
| Branch? | 2.0
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #1050
| License | MIT
Added new path resolver for relative paths creation
(RelativeWebPathResolver && RelativeWebPathResolverFactory)
usage example:
liip_imagine: resolvers: default: relative_web_path: web_root: "%kernel.root_dir%/../web" cache_prefix: assets