[WIP][Cache Resolver] Implement relative web path resolver #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Tests/Imagine/Cache/Resolver/WebPathResolverTest.php
# Conflicts: # Tests/DependencyInjection/ConfigurationTest.php # Tests/DependencyInjection/Factory/Resolver/WebPathResolverFactoryTest.php # Tests/DependencyInjection/LiipImagineExtensionTest.php # Tests/Imagine/Cache/Resolver/WebPathResolverTest.php
franmomu
changed the title
|
Hey @nmuntyanov @franmomu @michellesanver |
|
Hi, I don't think someone is working on it, feel free to take over. Based on the comments I wrote:
This should be done in a BC-break way.
Check if it's really needed the interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #1059 merged with the current master, I fixed the tests and conflicts,
but I haven't checked the implementation yet.EDIT:
WebPathResolvershouldn't be change in case someone has extended this class.PathResolverinside the class and I'm not sure if thePathResolverInterfaceis needed.