Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++] Define all CMake configuration features in the same location #115361

Merged
merged 2 commits into from
Nov 14, 2024
Merged

[libc++] Define all CMake configuration features in the same location #115361

merged 2 commits into from
Nov 14, 2024

Commits on Nov 11, 2024

  1. [libc++] Define all CMake configuration features in the same location 

    This moves the configuration of the CMake features to turn off
RTTI, exceptions and friends to the beginning of the CMake file,
where we configure other optional parts of the library.

This fixes an important bug where we would disable the benchmarks
because these options were not defined yet, leading to the build
thinking they were defined to OFF.
    @ldionne
    ldionne committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    76ee846 View commit details
    Browse the repository at this point in the history

  2. Fix linker error with static library configuration

    @ldionne
    ldionne committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0f10a25 View commit details
    Browse the repository at this point in the history