Skip to content

[lldb] Disable statusline on Windows #138111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

[lldb] Disable statusline on Windows #138111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Core/CoreProperties.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ let Definition = "debugger" in {
def ShowStatusline: Property<"show-statusline", "Boolean">,
Global,
DefaultTrue,
Desc<"Whether to show a statusline at the bottom of the terminal.">;
Desc<"Whether to show a statusline at the bottom of the terminal (not supported on Windows).">;
def Separator : Property<"separator", "String">,
Global,
DefaultStringValue<"│ ">,
Expand Down
4 changes: 4 additions & 0 deletions lldb/source/Core/Debugger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2031,13 +2031,17 @@ void Debugger::CancelForwardEvents(const ListenerSP &listener_sp) {
}

bool Debugger::StatuslineSupported() {
// We have trouble with the contol codes on Windows, see
// https://github.com/llvm/llvm-project/issues/134846.
#ifndef _WIN32
if (GetShowStatusline()) {
if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) {
File &file = stream_sp->GetUnlockedFile();
return file.GetIsInteractive() && file.GetIsRealTerminal() &&
file.GetIsTerminalWithColors();
}
}
#endif
return false;
}

Expand Down
3 changes: 2 additions & 1 deletion llvm/docs/ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,8 @@ Changes to LLDB
* A statusline was added to command-line LLDB to show progress events and
information about the current state of the debugger at the bottom of the
terminal. This is on by default and can be configured using the
`show-statusline` and `statusline-format` settings.
`show-statusline` and `statusline-format` settings. It is not currently
supported on Windows.
* The `min-gdbserver-port` and `max-gdbserver-port` options have been removed
from `lldb-server`'s platform mode. Since the changes to `lldb-server`'s port
handling in LLDB 20, these options have had no effect.
Expand Down
Loading