[llvm][docs] Reorder Stacked PR approaches in GitHub.rst #138126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'user branches' approach now appears before the 'dependency note' approach, as it makes reviewing easier. Add notes on requiring commit access for the former and on the disadvantage of the latter.
banach-space
reviewed
May 1, 2025
| note in the PR summary indicating that it depends on PR_1 (e.g., | ||
| “Depends on #PR_1”). | ||
|
|
||
| The disadvantage of this approach is that GitHub will not show a clean diff. |
There was a problem hiding this comment.
Note the note below:
When not using user branches, GitHub will not display proper diffs for
subsequent PRs in a stack. Instead, it will show a combined diff that
includes all commits from earlier PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'user branches' approach now appears before the 'dependency note' approach, as it makes reviewing easier.
Add notes on requiring commit access for the former and on the disadvantage of the latter.