-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[OpenACC][CIR] 'cache' construct lowering #146915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erichkeane
wants to merge
1
commit into
llvm:main
Choose a base branch
from
erichkeane:CacheLowering
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // Generic OpenACC lowering functions not Stmt, Decl, or clause specific. | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "CIRGenFunction.h" | ||
| #include "mlir/Dialect/Arith/IR/Arith.h" | ||
| #include "mlir/Dialect/OpenACC/OpenACC.h" | ||
| #include "clang/AST/ExprCXX.h" | ||
|
|
||
| using namespace clang; | ||
| using namespace clang::CIRGen; | ||
|
|
||
| namespace { | ||
| mlir::Value createBound(CIRGenFunction &cgf, CIRGen::CIRGenBuilderTy &builder, | ||
| mlir::Location boundLoc, mlir::Value lowerBound, | ||
| mlir::Value upperBound, mlir::Value extent) { | ||
| // Arrays always have a start-idx of 0. | ||
| mlir::Value startIdx = cgf.createOpenACCConstantInt(boundLoc, 64, 0); | ||
| // Stride is always 1 in C/C++. | ||
| mlir::Value stride = cgf.createOpenACCConstantInt(boundLoc, 64, 1); | ||
|
|
||
| auto bound = | ||
| builder.create<mlir::acc::DataBoundsOp>(boundLoc, lowerBound, upperBound); | ||
| bound.getStartIdxMutable().assign(startIdx); | ||
| if (extent) | ||
| bound.getExtentMutable().assign(extent); | ||
| bound.getStrideMutable().assign(stride); | ||
|
|
||
| return bound; | ||
| } | ||
| } // namespace | ||
|
|
||
| mlir::Value CIRGenFunction::emitOpenACCIntExpr(const Expr *intExpr) { | ||
| mlir::Value expr = emitScalarExpr(intExpr); | ||
| mlir::Location exprLoc = cgm.getLoc(intExpr->getBeginLoc()); | ||
|
|
||
| mlir::IntegerType targetType = mlir::IntegerType::get( | ||
| &getMLIRContext(), getContext().getIntWidth(intExpr->getType()), | ||
| intExpr->getType()->isSignedIntegerOrEnumerationType() | ||
| ? mlir::IntegerType::SignednessSemantics::Signed | ||
| : mlir::IntegerType::SignednessSemantics::Unsigned); | ||
|
|
||
| auto conversionOp = builder.create<mlir::UnrealizedConversionCastOp>( | ||
| exprLoc, targetType, expr); | ||
| return conversionOp.getResult(0); | ||
| } | ||
|
|
||
| mlir::Value CIRGenFunction::createOpenACCConstantInt(mlir::Location loc, | ||
| unsigned width, | ||
| int64_t value) { | ||
| mlir::IntegerType ty = | ||
| mlir::IntegerType::get(&getMLIRContext(), width, | ||
| mlir::IntegerType::SignednessSemantics::Signless); | ||
| auto constOp = builder.create<mlir::arith::ConstantOp>( | ||
| loc, builder.getIntegerAttr(ty, value)); | ||
|
|
||
| return constOp.getResult(); | ||
| } | ||
|
|
||
| CIRGenFunction::OpenACCDataOperandInfo | ||
| CIRGenFunction::getOpenACCDataOperandInfo(const Expr *e) { | ||
| const Expr *curVarExpr = e->IgnoreParenImpCasts(); | ||
|
|
||
| mlir::Location exprLoc = cgm.getLoc(curVarExpr->getBeginLoc()); | ||
| llvm::SmallVector<mlir::Value> bounds; | ||
|
|
||
| std::string exprString; | ||
| llvm::raw_string_ostream os(exprString); | ||
| e->printPretty(os, nullptr, getContext().getPrintingPolicy()); | ||
|
|
||
| while (isa<ArraySectionExpr, ArraySubscriptExpr>(curVarExpr)) { | ||
| mlir::Location boundLoc = cgm.getLoc(curVarExpr->getBeginLoc()); | ||
| mlir::Value lowerBound; | ||
| mlir::Value upperBound; | ||
| mlir::Value extent; | ||
|
|
||
| if (const auto *section = dyn_cast<ArraySectionExpr>(curVarExpr)) { | ||
| if (const Expr *lb = section->getLowerBound()) | ||
| lowerBound = emitOpenACCIntExpr(lb); | ||
| else | ||
| lowerBound = createOpenACCConstantInt(boundLoc, 64, 0); | ||
|
|
||
| if (const Expr *len = section->getLength()) { | ||
| extent = emitOpenACCIntExpr(len); | ||
| } else { | ||
| QualType baseTy = ArraySectionExpr::getBaseOriginalType( | ||
| section->getBase()->IgnoreParenImpCasts()); | ||
| // We know this is the case as implicit lengths are only allowed for | ||
| // array types with a constant size, or a dependent size. AND since | ||
| // we are codegen we know we're not dependent. | ||
| auto *arrayTy = getContext().getAsConstantArrayType(baseTy); | ||
| // Rather than trying to calculate the extent based on the | ||
| // lower-bound, we can just emit this as an upper bound. | ||
| upperBound = createOpenACCConstantInt(boundLoc, 64, | ||
| arrayTy->getLimitedSize() - 1); | ||
| } | ||
|
|
||
| curVarExpr = section->getBase()->IgnoreParenImpCasts(); | ||
| } else { | ||
| const auto *subscript = cast<ArraySubscriptExpr>(curVarExpr); | ||
|
|
||
| lowerBound = emitOpenACCIntExpr(subscript->getIdx()); | ||
| // Length of an array index is always 1. | ||
| extent = createOpenACCConstantInt(boundLoc, 64, 1); | ||
| curVarExpr = subscript->getBase()->IgnoreParenImpCasts(); | ||
| } | ||
|
|
||
| bounds.push_back(createBound(*this, this->builder, boundLoc, lowerBound, | ||
| upperBound, extent)); | ||
| } | ||
|
|
||
| if (const auto *memExpr = dyn_cast<MemberExpr>(curVarExpr)) | ||
| return {exprLoc, emitMemberExpr(memExpr).getPointer(), exprString, | ||
| std::move(bounds)}; | ||
|
|
||
| // Sema has made sure that only 4 types of things can get here, array | ||
| // subscript, array section, member expr, or DRE to a var decl (or the | ||
| // former 3 wrapping a var-decl), so we should be able to assume this is | ||
| // right. | ||
| const auto *dre = cast<DeclRefExpr>(curVarExpr); | ||
| return {exprLoc, emitDeclRefLValue(dre).getPointer(), exprString, | ||
| std::move(bounds)}; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the loop op is an ACC specific one , should this be renamed
ActiveACCLoopRAIIor similar?